You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/12 12:20:52 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #32129: [SPARK-35028][SQL] ANSI mode: disallow group by aliases

gengliangwang commented on a change in pull request #32129:
URL: https://github.com/apache/spark/pull/32129#discussion_r611578608



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -206,6 +206,17 @@ object SQLConf {
     .intConf
     .createWithDefault(100)
 
+  val ANSI_ENABLED = buildConf("spark.sql.ansi.enabled")

Review comment:
       Moving `ANSI_ENABLED` to the front so that other configurations can refer to it without compiling errors.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org