[GitHub] [skywalking] peng-yongsheng commented on issue #3017: fix deleteIndex repeat append namespace

[GitBox <gi...@apache.org>]

peng-yongsheng commented on issue #3017: fix deleteIndex repeat append namespace
URL: https://github.com/apache/skywalking/pull/3017#issuecomment-509677063
 
 
   This 
   
   > > I'm not suggest fixed it by this way. You can just add a new delete method without format. It is a very simply way.
   > 
   > @peng-yongsheng That kind of delete is very hard to understand from API use perspective. When to use delete with prefix, when don't? That is also very hard to review.
   > I hope you have a better suggestion, but a new delete with string just without format inside, looks not good.
   
   Although it is hard to understand, it is the best way. This is the implementation of the Elasticsearch.
   Before you modify it, some things you must know.
   - Template index_patterns 
   - Template aliases
   - Template retrieval Index by aliases
   Those things are difficult to understand. Retrieval index by aliases, return the index name with the namespace, then substring it from the index name, then join together the namespace in the delete method. This is a strange operation. Unless we don't use aliases to retrieval Index.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services