You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "flyrain (via GitHub)" <gi...@apache.org> on 2025/01/23 23:41:21 UTC
[I] Failed to run run_spark_sql.sh [polaris]
flyrain opened a new issue, #865:
URL: https://github.com/apache/polaris/issues/865
### Describe the bug
The fixed token(`principal:root;realm:default-realm`) for regression test doesn't work any more. It worked before the Quarkus migration. cc @eric-maynard
### To Reproduce
_No response_
### Actual Behavior
_No response_
### Expected Behavior
_No response_
### Additional context
_No response_
### System information
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2611415896
Thanks for the finding, @HonahX! It works without changing the credential as well, see #866. I think the class `TestInlineBearerTokenPolarisAuthenticator` is the one not checking the token, which is set by `polaris.authentication.authenticator.type: test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2611359566
Seems we need to add some additional env to make the fixed token work
I followed the docker compose yaml and adding the following env to getting-started trino example
https://github.com/apache/polaris/blob/ee26660f08041b5d2ef08c6a490d88f2a846e4ba/regtests/docker-compose.yml#L34-L42
and I got authorized to create the catalog via `principal:root;realm:default-realm`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2611525980
I'm OK if we decided to go that direction, that means all places with the token `principal:root;realm:default-realm` needed to be replaced with the token generation script, and we probably don't need the class `TestInlineBearerTokenPolarisAuthenticator` any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2613270639
+1 consolidate authenticator.
With a setting like this, there seems no need to keep test authenticator around. PoC, demos and quickstart can also use the default one.
```
jvmArgs = listOf("-Dpolaris.bootstrap.credentials=POLARIS,root,secret")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode closed issue #865: Failed to run run_spark_sql.sh
URL: https://github.com/apache/polaris/issues/865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2614198990
This is verified with the current main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2611517216
So here is this one which @adutra created (not yet ready for review): https://github.com/apache/polaris/pull/804/files
It used the following snippet to pass around token for the test:
```
if ! output=$(curl -X POST -H "Polaris-Realm: POLARIS" "http://${POLARIS_HOST:-localhost}:8181/api/catalog/v1/oauth/tokens" \
-d "grant_type=client_credentials" \
-d "client_id=root" \
-d "client_secret=secret" \
-d "scope=PRINCIPAL_ROLE:ALL"); then
logred "Error: Failed to retrieve bearer token"
exit 1
fi
token=$(echo "$output" | awk -F\" '{print $4}')
export REGTEST_ROOT_BEARER_TOKEN=$token
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2611528873
Yes, I am still reading through recent changes. @adutra what do u think? Should we proceed with #804 as docker change is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Failed to run run_spark_sql.sh [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on issue #865:
URL: https://github.com/apache/polaris/issues/865#issuecomment-2612059626
Hi @MonkeyCanCode @flyrain @HonahX sorry for creating so much confusion here.
Here is my long term vision:
- I think the test profile (used in automated tests) is too different from the prod profile. It is always good to make those converge as much as possible. That's why I opened #786. I think it would be good to merge that one quickly, I will do it today.
- I also think that the regression tests should strive to use the same config as in production. This is not the case today, as you noticed, which is why I think you opened this issue. I started a PR (in draft) here: #804 where the authenticator for regression tests is changed to use the production one.
- As much as possible, I think that the `test` authenticator + token broker should only be used for prototyping, quickstart guides and demos, but not for tests.
Does that make sense?
If that's OK with you, let's proceed as follows:
- Get #786 merged
- Get #804 reviewed and merged
- Revisit the docs and fix all the places where the regression tests are not launched with the appropriate parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org