You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/16 13:17:11 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #17693: [feat][CI] Add approval solution to reduce GitHub Actions resource consumption

lhotari commented on code in PR #17693:
URL: https://github.com/apache/pulsar/pull/17693#discussion_r973014087


##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -60,6 +60,11 @@ jobs:
           echo "::set-output name=docs_only::${{ fromJSON(steps.changes.outputs.all_count) == fromJSON(steps.changes.outputs.docs_count) && fromJSON(steps.changes.outputs.docs_count) > 0 }}"
           echo "::set-output name=cpp_only::${{ fromJSON(steps.changes.outputs.all_count) == fromJSON(steps.changes.outputs.cpp_count) && fromJSON(steps.changes.outputs.cpp_count) > 0 }}"
 
+      - name: Check if the PR has been approved for testing

Review Comment:
   Yes, makes sense to rename to "Preconditions"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org