You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/25 08:56:10 UTC

[GitHub] [flink] banmoy opened a new pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

banmoy opened a new pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685
 
 
   ## What is the purpose of the change
   Refactor bucketing sink e2e test to make it more stable and comprehensible.
   
   ## Brief change log
   
   - For `BucketingSinkTestProgram`, set inactiveBucketCheckInterval and inactiveBucketThreshold to 2000 and 4000 respectively
   - only count records in part-* files to get total valid data
   - remove "sleep 10" between two failover to make it comprehensible
   
   ## Verifying this change
   
   Existing e2e test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:MANUAL TriggerID:574942577
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144549267) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-569085964
 
 
   @flinkbot run azure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574942495
 
 
   travis on ce56c02 failed with `BackPressureITCase` which is tracked in [FLINK-15247](https://issues.apache.org/jira/browse/FLINK-15247), and rerun travis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] kl0u closed pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568869384
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 18d9268b1f2106fceaffe388ff9e4e1babdad452 (Wed Dec 25 08:59:14 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#discussion_r366923058
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_streaming_bucketing.sh
 ##########
 @@ -27,7 +27,7 @@ function get_total_number_of_valid_lines {
   # this method assumes that pending files contain valid data.
 
 Review comment:
   The comment is now invalid as we do not assume that pending files have valid data anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144549267) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144549267) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:MANUAL TriggerID:574942577
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:MANUAL TriggerID:574942577
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144549267) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574942577
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] kl0u commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-575068069
 
 
   Thanks for the work @banmoy ! Merged it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574734638
 
 
   @kl0u Thanks for your review.  In `StreamingFileSink` end-to-end test, `OnCheckpointRollingPolicy` ensures in-progress part files will be rolled to part files finally, so I think there is no need to enable inactive check. I update the PR, and please have a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568872421
 
 
   <!--
   Meta data
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:PUSH TriggerID:18d9268b1f2106fceaffe388ff9e4e1babdad452
   Hash:18d9268b1f2106fceaffe388ff9e4e1babdad452 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908 TriggerType:MANUAL TriggerID:569085964
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:PUSH TriggerID:d2686edf78b4d3afec05ca65486ff26304000aeb
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353493 TriggerType:MANUAL TriggerID:570495127
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:568911583
   Hash:d2686edf78b4d3afec05ca65486ff26304000aeb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150 TriggerType:MANUAL TriggerID:570495127
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:PUSH TriggerID:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144549267 TriggerType:MANUAL TriggerID:574942577
   Hash:ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377 TriggerType:MANUAL TriggerID:574942577
   -->
   ## CI report:
   
   * 18d9268b1f2106fceaffe388ff9e4e1babdad452 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3908) 
   * d2686edf78b4d3afec05ca65486ff26304000aeb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4150) 
   * ce56c02026fdf5e8663b6bcd00e9a3bebbe38e65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144549267) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4377) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-571470741
 
 
   @kl0u Can you help to review this PR? Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-570495127
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-572019298
 
 
   @kl0u is currently on vacation but I'm sure he'll have a look once he's back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#discussion_r366923298
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_streaming_bucketing.sh
 ##########
 @@ -150,7 +148,7 @@ wait_job_terminal_state ${JOB_ID} "CANCELED"
 echo "Job $JOB_ID was cancelled, time to verify"
 
 # get all lines in pending or part files
 
 Review comment:
   The comment is now invalid as we do not get the lines in the pending files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568911583
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#discussion_r366922616
 
 

 ##########
 File path: flink-end-to-end-tests/flink-bucketing-sink-test/src/main/java/org/apache/flink/streaming/tests/BucketingSinkTestProgram.java
 ##########
 @@ -74,8 +74,8 @@ public static void main(String[] args) throws Exception {
 				.setBucketer(new KeyBucketer())
 				.setBatchSize(Long.MAX_VALUE)
 				.setBatchRolloverInterval(Long.MAX_VALUE)
-				.setInactiveBucketCheckInterval(Long.MAX_VALUE)
-				.setInactiveBucketThreshold(Long.MAX_VALUE);
+				.setInactiveBucketCheckInterval(2000)
 
 Review comment:
   Why not setting the values to something smaller so that the test runs faster?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services