[GitHub] [incubator-superset] axuew commented on issue #8554: Fix hana time filter

[GitBox <gi...@apache.org>]

axuew commented on issue #8554: Fix hana time filter
URL: https://github.com/apache/incubator-superset/pull/8554#issuecomment-553755538
 
 
   
   > Can you explain what the intent of this change is? It would be helpful to understand what problem it solves, as I believe this need some additional work before it can be merged.
   
   Sorry, we didn't test it carefully last time, so there was a bug in the use process. Now we will fix it after the detailed test. Sqlalchemy-han returns the complete time type without DATA and TIMESTAMP
   
           """
           Tested: hana time returns DATETIME and STRING
           HANA:
           :return dttm->DATETIME
           HANA->DATE:f"TO_DATE('{dttm.date().isoformat()}', 'YYYY-MM-DD')"
            :return dttm->DATETIME
           HANA->TIMESTAMP:
           f"TO_TIMESTAMP('{dttm.isoformat(timespec="microseconds")}',
           'YYYY-MM-DD"T"HH24:MI:SS.ff6')"
            :return dttm->STRING
           HANA->NVARCHAR TYPE:f"TO_CHAR('{dttm.date().isoformat()}', 'YYYYMMDD')"
           """

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org