You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/03/16 09:14:39 UTC
[GitHub] lytscu commented on a change in pull request #950: [Agent] Provide plugin for Tomcat 6.x
lytscu commented on a change in pull request #950: [Agent] Provide plugin for Tomcat 6.x
URL: https://github.com/apache/incubator-skywalking/pull/950#discussion_r175031764
##########
File path: apm-sniffer/apm-sdk-plugin/tomcat-7.x-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat78x/define/TomcatInstrumentation.java
##########
@@ -93,4 +93,13 @@ public boolean isOverrideArgs() {
}
};
}
+ @Override
+ protected String[] witnessClasses() {
+ /**
+ * @see <code>javax.servlet.annotation.HandlesTypes<code/>
+ */
+ return new String[] {
+ "javax.servlet.annotation.HandlesTypes"
Review comment:
Tomcat 6 work in servlet-api 2.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services