You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2012/11/15 15:06:09 UTC

Re: [jira] [Closed] (OPENEJB-1937) commons-dbcp doesn't clean its transactionregistry maps

Hi guys,

do we backport it in 4.5.1 branch?

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*




2012/11/15 Romain Manni-Bucau (JIRA) <ji...@apache.org>

>
>      [
> https://issues.apache.org/jira/browse/OPENEJB-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Romain Manni-Bucau closed OPENEJB-1937.
> ---------------------------------------
>
>     Resolution: Fixed
>
> > commons-dbcp doesn't clean its transactionregistry maps
> > -------------------------------------------------------
> >
> >                 Key: OPENEJB-1937
> >                 URL: https://issues.apache.org/jira/browse/OPENEJB-1937
> >             Project: OpenEJB
> >          Issue Type: Bug
> >    Affects Versions: 4.5.0
> >            Reporter: Romain Manni-Bucau
> >
>
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Re: [jira] [Closed] (OPENEJB-1937) commons-dbcp doesn't clean its transactionregistry maps

Posted by Romain Manni-Bucau <rm...@gmail.com>.
yep looks close

i reverted currently because was too aggressive

the issue is mainly it is quite easy to clean xaresources map but caches is
harder to clean with current code

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*




2012/11/15 AndyG <an...@orprovision.com>

> Breaks my app.
>
> 2012-11-15 16:54:45,078 WARN
> [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (ejbd 5) SQL Error: 0,
> SQLState: null
> 2012-11-15 16:54:45,078 ERROR
> [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (ejbd 5) Connection does
> not have a registered XAResource jdbc:postgresql://[url removed],
> PostgreSQL
> Native Driver
> 2012-11-15 16:54:45,081 ERROR
> [com.orprovision.spectrum.storage.bean.server.PreferencesFactoryImpl] (ejbd
> 5) hasPreferences
> javax.persistence.PersistenceException:
> org.hibernate.exception.GenericJDBCException: Could not open connection
>
> It looks very similar to this (But I am using Sun JDK 1.6.36):
> https://issues.apache.org/jira/browse/DBCP-356
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Re-jira-Closed-OPENEJB-1937-commons-dbcp-doesn-t-clean-its-transactionregistry-maps-tp4658631p4658632.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: [jira] [Closed] (OPENEJB-1937) commons-dbcp doesn't clean its transactionregistry maps

Posted by AndyG <an...@orprovision.com>.
Breaks my app.

2012-11-15 16:54:45,078 WARN 
[org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (ejbd 5) SQL Error: 0,
SQLState: null
2012-11-15 16:54:45,078 ERROR
[org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (ejbd 5) Connection does
not have a registered XAResource jdbc:postgresql://[url removed], PostgreSQL
Native Driver
2012-11-15 16:54:45,081 ERROR
[com.orprovision.spectrum.storage.bean.server.PreferencesFactoryImpl] (ejbd
5) hasPreferences
javax.persistence.PersistenceException:
org.hibernate.exception.GenericJDBCException: Could not open connection

It looks very similar to this (But I am using Sun JDK 1.6.36):
https://issues.apache.org/jira/browse/DBCP-356



--
View this message in context: http://openejb.979440.n4.nabble.com/Re-jira-Closed-OPENEJB-1937-commons-dbcp-doesn-t-clean-its-transactionregistry-maps-tp4658631p4658632.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: [jira] [Closed] (OPENEJB-1937) commons-dbcp doesn't clean its transactionregistry maps

Posted by Romain Manni-Bucau <rm...@gmail.com>.
well it could if instead of adding a transactionlistener it'd use the
delistXAResource hook, no?

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*




2012/11/15 AndyG <an...@orprovision.com>

> The revert fixes it - Does not look like it's going to be an easy fix
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Re-jira-Closed-OPENEJB-1937-commons-dbcp-doesn-t-clean-its-transactionregistry-maps-tp4658631p4658633.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: [jira] [Closed] (OPENEJB-1937) commons-dbcp doesn't clean its transactionregistry maps

Posted by AndyG <an...@orprovision.com>.
The revert fixes it - Does not look like it's going to be an easy fix 



--
View this message in context: http://openejb.979440.n4.nabble.com/Re-jira-Closed-OPENEJB-1937-commons-dbcp-doesn-t-clean-its-transactionregistry-maps-tp4658631p4658633.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.