You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airavata.apache.org by ma...@apache.org on 2023/05/03 14:12:06 UTC
[airavata-data-catalog] 05/09: Don't need to call onCompleted after onError

This is an automated email from the ASF dual-hosted git repository.

machristie pushed a commit to branch custos-integration
in repository https://gitbox.apache.org/repos/asf/airavata-data-catalog.git

commit 25a3eae6dedd30977608ec7328a83592aae06cf2
Author: Marcus Christie <ma...@apache.org>
AuthorDate: Wed May 3 09:39:14 2023 -0400

    Don't need to call onCompleted after onError
---
 .../datacatalog/api/service/DataCatalogAPIService.java       | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/data-catalog-api/server/service/src/main/java/org/apache/airavata/datacatalog/api/service/DataCatalogAPIService.java b/data-catalog-api/server/service/src/main/java/org/apache/airavata/datacatalog/api/service/DataCatalogAPIService.java
index 77b5bda..ef532d5 100644
--- a/data-catalog-api/server/service/src/main/java/org/apache/airavata/datacatalog/api/service/DataCatalogAPIService.java
+++ b/data-catalog-api/server/service/src/main/java/org/apache/airavata/datacatalog/api/service/DataCatalogAPIService.java
@@ -80,7 +80,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
         } catch (SharingException e) {
             logger.error("Sharing error when trying to create data product", e);
             responseObserver.onError(Status.INTERNAL.withDescription(e.getMessage()).asException());
-            responseObserver.onCompleted();
         }
 
     }
@@ -102,7 +101,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.withDescription(e.getMessage()).asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -120,7 +118,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -139,7 +136,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -164,7 +160,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.withDescription(e.getMessage()).asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -189,7 +184,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.withDescription(e.getMessage()).asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -206,11 +200,9 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
         } catch (MetadataSchemaSqlParseException e) {
             responseObserver
                     .onError(Status.INVALID_ARGUMENT.withDescription("Failed to parse SQL query.").asException());
-            responseObserver.onCompleted();
         } catch (MetadataSchemaSqlValidateException e) {
             responseObserver
                     .onError(Status.INVALID_ARGUMENT.withDescription("Failed to validate SQL query.").asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -224,7 +216,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -249,7 +240,6 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
             responseObserver.onCompleted();
         } catch (EntityNotFoundException e) {
             responseObserver.onError(Status.NOT_FOUND.asException());
-            responseObserver.onCompleted();
         }
     }
 
@@ -318,14 +308,12 @@ public class DataCatalogAPIService extends DataCatalogAPIServiceGrpc.DataCatalog
                 responseObserver.onError(Status.PERMISSION_DENIED
                         .withDescription("user does not have " + permission + " permission")
                         .asException());
-                responseObserver.onCompleted();
                 return false;
             } else {
                 return true;
             }
         } catch (SharingException e) {
             responseObserver.onError(Status.INTERNAL.withDescription(e.getMessage()).asException());
-            responseObserver.onCompleted();
         }
         return false;
     }