You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 21:03:54 UTC

[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2298: Always increment timer on record

tustvold opened a new pull request, #2298:
URL: https://github.com/apache/arrow-datafusion/pull/2298

   # Rationale for this change
   
   #2261 added a test that elapsed_compute was recorded in metrics, unfortunately in the case of LocalLimitExec and GlobalLimitExec the operator body is too small to reliable take time, and as such this test is flaky
   
   * https://github.com/apache/arrow-datafusion/runs/6100177086?check_suite_focus=true
   * https://github.com/apache/arrow-datafusion/runs/6100277301?check_suite_focus=true
   * https://github.com/apache/arrow-datafusion/runs/6100969854?check_suite_focus=true
   
   Additionally when rendering plan metrics, a value if 0 is translated to "NOT RECORDED" - https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/metrics/value.rs#L540
   
   # What changes are included in this PR?
   
   This changes `Time::add_duration` and `Time::add` to always record at least one nanosecond. 
   
   # Are there any user-facing changes?
   
   Yes, calling `Timer::add_duration` will now always record at least 1 nanosecond


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold merged pull request #2298: Always increment timer on record

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2298:
URL: https://github.com/apache/arrow-datafusion/pull/2298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] yjshen commented on pull request #2298: Always increment timer on record

Posted by GitBox <gi...@apache.org>.
yjshen commented on PR #2298:
URL: https://github.com/apache/arrow-datafusion/pull/2298#issuecomment-1104574500

   I manually rerun all failure checks for the latest PRs because of this flaky test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #2298: Always increment timer on record

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2298:
URL: https://github.com/apache/arrow-datafusion/pull/2298#issuecomment-1104471050

   ITS TOO FAST!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] yjshen commented on pull request #2298: Always increment timer on record

Posted by GitBox <gi...@apache.org>.
yjshen commented on PR #2298:
URL: https://github.com/apache/arrow-datafusion/pull/2298#issuecomment-1104565603

   Thanks for the fixing!
   
   I found this test flaky and added the [assertion failure message](https://github.com/apache/arrow-datafusion/pull/2261/commits/ab153760f8439d5859d529d02a3f598fb4433129) in #2261 but failed to reproduce it in later trials.
   
   Previous failure before the assertion log:
   https://github.com/apache/arrow-datafusion/runs/6091653680?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org