You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:07:19 UTC

[GitHub] [skywalking-showcase] JaredTan95 commented on a change in pull request #2: Fix wait for es

JaredTan95 commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-showcase/pull/2#discussion_r748049290



##########
File path: Makefile.in
##########
@@ -26,6 +26,8 @@ TAG ?= $(shell git rev-parse --short HEAD)
 
 ES_VERSION ?= 7.10.0
 
+BUSYBOX_VERSION ?= 1.30

Review comment:
       It is better configurable,  whether the user needs to change it or not. I'm ok with both.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org