You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/27 15:57:14 UTC

[GitHub] [echarts] plainheart commented on issue #15949: SVG render issue when theme values stored as strings

plainheart commented on issue #15949:
URL: https://github.com/apache/echarts/issues/15949#issuecomment-953068619


   This is definitely caused by an unexpected `lineWidth` of type `string`.  Let's take a look at the `rect` command in SVG path builder. https://github.com/ecomfe/zrender/blob/master/src/svg/graphic.ts#L247-L253
   We will find there will be a calculation error when the `width/height` of type `string` plus the numeric `x/y`.
   
   I'm not sure if it's necessary to be fixed. But anyway, we should ensure that the `lineWidth` is a number.  @pissang 
   
   The theme builder does need further improvement. @Ovilia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org