[GitHub] erisu commented on issue #377: Increase Code Coverage & use nyc

[GitBox <gi...@apache.org>]

erisu commented on issue #377: Increase Code Coverage & use nyc
URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409431284
 
 
   @brodybits 
   
   With the recent mailing list discussion, to mark the next major Cordova dev release (cordova-ios@5.0.0-dev),
   does it mean we can and will drop Node.js 4 for cordova-io after the release?
   
   Some repos have already dropped Node 4 support and began using  `let`, `const`, `class` etc in master. For example cordova-android.
   
   As for using `var` vs. `let & const`. I would hope to continue to use let and const if we plan to merge this after the bump and the usage at that time is OK. 
   
   Since the other repos are starting to use them, why not all. 
   I know the drop support task will take time to complete across all repos. I would like to have a uniform coding syntax across all repos but, I know it will be difficult. Als everyone has their own coding preference anyways. he
   
   As for the transitioning of var declarations to let and const. I had been making these changes as I go, not mass search and replace.
   
   I also agree and excited to see the committed node_modules removed. I have always been wondering behind this.
   
   `do not upgrade eslint devDeps in this PR` 
   I suspect this means to revert the eslint only devDeps from my PR, and we will be handled in #382 ?
   
   The only concern I had with the other PR was the `@next` devDeps usage. I don't normally recommend using non-official release deps in production, though its only used for testing/linting and would not affect user projects.
   
   I haven't looked too much into why it was decided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org