Re: [PATCH] Added "app" column to tomcat$sessions

[Glenn Nielsen <gl...@mail.more.net>]

Tom,

Thanks for your patches for JDBCStore.

I have been going through the tomcat-dev list and bugzilla to find
all bugs/patches and am working on updating JDBCStore.

In the future you may want to create a bug report using bugzilla
and attach your patch to the bug report.  Your patches are less
likely to get overlooked if they are in bugzilla.

Thanks again,

Glenn

Tom Anderson wrote:
> I wrote a patch to JDBCStore.java that adds a new column to the 
> tomcat$sessions table to hold information about the webapp that is 
> trying to save the session.
> 
> The need for this comes when you run multiple webapps which each may 
> have classes in session that are unique to the webapp.  As written, 
> JDBCStore tries to pull all webapps from the database regardless of who 
> generated them.   Exceptions ensue.
> 
> With this patch, a webapp will only read and write sessions that belong 
> to it.   I much prefer this to creating multiple tomcat$session tables 
> because of the testing and maintenance aspects.   Hopefully somebody 
> will agree enough to consider applying this patch.
> 
> Cheers,
> ~Tom
> 
> p.s. With all the fixes I've submitted, my version of Tomcat has a much 
> more stable implementation of JDBCStore than the controlled version ... 
> good for me but bad for everyone else ... what's the trick to getting 
> the patches accepted?
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org