You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thomas Spiegl (JIRA)" <de...@myfaces.apache.org> on 2007/12/18 15:02:43 UTC

[jira] Created: (TRINIDAD-874) RequestQueue.js breaks tomahawk components

RequestQueue.js breaks tomahawk components
------------------------------------------

                 Key: TRINIDAD-874
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-874
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 1.0.5-core
            Reporter: Thomas Spiegl
            Assignee: Matthias Weßendorf


Trinidad ppr breaks tomahawk components by sending all input type=submit fields in the subsequent xhr request. 

t:panelTabbedPane for example will always queue a TabChangeEvent and therefore navigate directly to RenderResponsePhase when processing the Event in the ApplyRequestValuesPhase
UpdateModelPhase therefore never takes place and ppr seems not to work.

Looks like the error is in RequestQueue.js

187 TrRequestQueue.prototype._getPostbackContent
...
199 // todo: do not post values for non-triggering submit buttons
200 if (input.name && !input.disabled)

adding a check for submit buttons in line 200 fixes the problem
200 if (input.name && !input.disabled && !(input.tagName=="INPUT" && input.type=="submit")


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-874) RequestQueue.js breaks tomahawk components

Posted by "Thomas Spiegl (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Spiegl updated TRINIDAD-874:
-----------------------------------

    Status: Patch Available  (was: Open)

> RequestQueue.js breaks tomahawk components
> ------------------------------------------
>
>                 Key: TRINIDAD-874
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-874
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.5-core
>            Reporter: Thomas Spiegl
>            Assignee: Matthias Weßendorf
>
> Trinidad ppr breaks tomahawk components by sending all input type=submit fields in the subsequent xhr request. 
> t:panelTabbedPane for example will always queue a TabChangeEvent and therefore navigate directly to RenderResponsePhase when processing the Event in the ApplyRequestValuesPhase
> UpdateModelPhase therefore never takes place and ppr seems not to work.
> Looks like the error is in RequestQueue.js
> 187 TrRequestQueue.prototype._getPostbackContent
> ...
> 199 // todo: do not post values for non-triggering submit buttons
> 200 if (input.name && !input.disabled)
> adding a check for submit buttons in line 200 fixes the problem
> 200 if (input.name && !input.disabled && !(input.tagName=="INPUT" && input.type=="submit")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-874) RequestQueue.js breaks tomahawk components

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-874:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.5-core
                   1.0.5-core
           Status: Resolved  (was: Patch Available)

> RequestQueue.js breaks tomahawk components
> ------------------------------------------
>
>                 Key: TRINIDAD-874
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-874
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.5-core
>            Reporter: Thomas Spiegl
>            Assignee: Matthias Weßendorf
>             Fix For: 1.0.5-core, 1.2.5-core
>
>         Attachments: RequestQueue.js.patch
>
>
> Trinidad ppr breaks tomahawk components by sending all input type=submit fields in the subsequent xhr request. 
> t:panelTabbedPane for example will always queue a TabChangeEvent and therefore navigate directly to RenderResponsePhase when processing the Event in the ApplyRequestValuesPhase
> UpdateModelPhase therefore never takes place and ppr seems not to work.
> Looks like the error is in RequestQueue.js
> 187 TrRequestQueue.prototype._getPostbackContent
> ...
> 199 // todo: do not post values for non-triggering submit buttons
> 200 if (input.name && !input.disabled)
> adding a check for submit buttons in line 200 fixes the problem
> 200 if (input.name && !input.disabled && !(input.tagName=="INPUT" && input.type=="submit")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.