You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/08/21 09:59:09 UTC
Review Request 37673: SQOOP-2517: Sqoop2: Findbugs: Fix resource leak
problem in CommonRepositoryHandler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37673/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Fix resource leak problem in CommonRepositoryHandler
Diffs
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c090d8e
Diff: https://reviews.apache.org/r/37673/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 37673: SQOOP-2517: Sqoop2: Findbugs: Fix resource
leak problem in CommonRepositoryHandler
Posted by Jarek Cecho <ja...@apache.org>.
> On Aug. 21, 2015, 9:06 p.m., Abraham Elmahrek wrote:
> > Java 7 or newer only support try-with-resources. Requirements say Java 6 should be supported for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java.
I've synced up with Abe offline, we're missing updating documentation that Java 7 is required now that is covered in SQOOP-2520.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37673/#review96088
-----------------------------------------------------------
On Aug. 21, 2015, 7:59 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37673/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 7:59 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fix resource leak problem in CommonRepositoryHandler
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c090d8e
>
> Diff: https://reviews.apache.org/r/37673/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 37673: SQOOP-2517: Sqoop2: Findbugs: Fix resource
leak problem in CommonRepositoryHandler
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37673/#review96088
-----------------------------------------------------------
Java 7 or newer only support try-with-resources. Requirements say Java 6 should be supported for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java.
- Abraham Elmahrek
On Aug. 21, 2015, 7:59 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37673/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 7:59 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fix resource leak problem in CommonRepositoryHandler
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java c090d8e
>
> Diff: https://reviews.apache.org/r/37673/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>