You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:51:27 UTC

[GitHub] [hudi] danny0405 opened a new pull request #3381: [HUDI-2258] Metadata table for flink

danny0405 opened a new pull request #3381:
URL: https://github.com/apache/hudi/pull/3381


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 closed pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #3381:
URL: https://github.com/apache/hudi/pull/3381


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edd47ef7538db57248f9cf71097732dcb053a688 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 20d4cda110df84fa8c439e683bb84b0484ed0667 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 merged pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #3381:
URL: https://github.com/apache/hudi/pull/3381


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 20d4cda110df84fa8c439e683bb84b0484ed0667 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303) 
   * ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1329",
       "triggerID" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 465945ef9014366ef8b4657104329b5e5a222ecc Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1329) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 20d4cda110df84fa8c439e683bb84b0484ed0667 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303) 
   * ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edd47ef7538db57248f9cf71097732dcb053a688 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302) 
   * 20d4cda110df84fa8c439e683bb84b0484ed0667 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edd47ef7538db57248f9cf71097732dcb053a688 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1329",
       "triggerID" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310) 
   * 465945ef9014366ef8b4657104329b5e5a222ecc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1329) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "465945ef9014366ef8b4657104329b5e5a222ecc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310) 
   * 465945ef9014366ef8b4657104329b5e5a222ecc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on a change in pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#discussion_r682248124



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -248,7 +248,8 @@ protected void bootstrapIfNeeded(HoodieEngineContext engineContext, HoodieTableM
       if (!latestMetadataInstant.isPresent()) {
         LOG.warn("Metadata Table will need to be re-bootstrapped as no instants were found");
         rebootstrap = true;
-      } else if (datasetMetaClient.getActiveTimeline().isBeforeTimelineStarts(latestMetadataInstant.get().getTimestamp())) {
+      } else if (!latestMetadataInstant.get().getTimestamp().equals(SOLO_COMMIT_TIMESTAMP)
+          && datasetMetaClient.getActiveTimeline().isBeforeTimelineStarts(latestMetadataInstant.get().getTimestamp())) {

Review comment:
       Modify to avoid re-bootstrap for empty table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yuzhaojing commented on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
yuzhaojing commented on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-892310319


   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edd47ef7538db57248f9cf71097732dcb053a688 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302) 
   * 20d4cda110df84fa8c439e683bb84b0484ed0667 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     }, {
       "hash" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1303",
       "triggerID" : "20d4cda110df84fa8c439e683bb84b0484ed0667",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310",
       "triggerID" : "ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab7c145c737dc47fd3fc3121ab13e0d0f7ec40bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1310) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3381: [HUDI-2258] Metadata table for flink

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3381:
URL: https://github.com/apache/hudi/pull/3381#issuecomment-890891194


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302",
       "triggerID" : "edd47ef7538db57248f9cf71097732dcb053a688",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edd47ef7538db57248f9cf71097732dcb053a688 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1302) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org