[GitHub] [hive] pvary commented on a change in pull request #2475: HIVE-25328: Limit scope of REPLACE COLUMNS for Iceberg tables

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2475:
URL: https://github.com/apache/hive/pull/2475#discussion_r680976148



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -309,9 +309,8 @@ public void commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
   }
 
   @Override
-  public void rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, EnvironmentContext context)
-      throws MetaException {
-    if (Boolean.valueOf(context.getProperties().getOrDefault(MIGRATE_HIVE_TO_ICEBERG, "false"))) {
+  public void rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, EnvironmentContext context) {
+    if (Boolean.parseBoolean(context.getProperties().getOrDefault(MIGRATE_HIVE_TO_ICEBERG, "false"))) {

Review comment:
       What is the difference here?
   ```
     public static Boolean valueOf(String var0) {
       return parseBoolean(var0) ? TRUE : FALSE;
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org