You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2016/10/23 17:54:36 UTC
[lang] Add final modifier to private fields.
Repository: commons-lang
Updated Branches:
refs/heads/master 4f82195af -> 607e3447c
Add final modifier to private fields.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/607e3447
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/607e3447
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/607e3447
Branch: refs/heads/master
Commit: 607e3447c92754d871a3f2eb8c472e45afed6c1c
Parents: 4f82195
Author: Gary Gregory <gg...@apache.org>
Authored: Sun Oct 23 10:54:34 2016 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Sun Oct 23 10:54:34 2016 -0700
----------------------------------------------------------------------
.../lang3/builder/MultilineRecursiveToStringStyle.java | 2 +-
.../java/org/apache/commons/lang3/builder/ToStringStyle.java | 2 +-
.../org/apache/commons/lang3/builder/EqualsBuilderTest.java | 4 ++--
.../apache/commons/lang3/builder/HashCodeBuilderTest.java | 8 ++++----
.../commons/lang3/time/FastDatePrinterTimeZonesTest.java | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/607e3447/src/main/java/org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.java b/src/main/java/org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.java
index d54e8b9..a2e4d4d 100644
--- a/src/main/java/org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.java
+++ b/src/main/java/org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.java
@@ -71,7 +71,7 @@ public class MultilineRecursiveToStringStyle extends RecursiveToStringStyle {
private static final long serialVersionUID = 1L;
/** Indenting of inner lines. */
- private int indent = 2;
+ private final int indent = 2;
/** Current indenting. */
private int spaces = 2;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/607e3447/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
index 8a8e653..4e43e52 100644
--- a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
+++ b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
@@ -2367,7 +2367,7 @@ public abstract class ToStringStyle implements Serializable {
/**
* The summary size text start <code>'>'</code>.
*/
- private String FIELD_NAME_PREFIX = "\"";
+ private final String FIELD_NAME_PREFIX = "\"";
/**
* <p>
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/607e3447/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
index 82aac5e..1f29a57 100644
--- a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
@@ -1150,8 +1150,8 @@ public class EqualsBuilderTest {
static class TestObjectEqualsExclude {
@EqualsExclude
- private int a;
- private int b;
+ private final int a;
+ private final int b;
public TestObjectEqualsExclude(int a, int b) {
this.a = a;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/607e3447/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
index b268546..1ad2116 100644
--- a/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
@@ -565,8 +565,8 @@ public class HashCodeBuilderTest {
static class TestObjectHashCodeExclude {
@HashCodeExclude
- private int a;
- private int b;
+ private final int a;
+ private final int b;
public TestObjectHashCodeExclude(int a, int b) {
this.a = a;
@@ -584,9 +584,9 @@ public class HashCodeBuilderTest {
static class TestObjectHashCodeExclude2 {
@HashCodeExclude
- private int a;
+ private final int a;
@HashCodeExclude
- private int b;
+ private final int b;
public TestObjectHashCodeExclude2(int a, int b) {
this.a = a;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/607e3447/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
index e669a24..e13e780 100644
--- a/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java
@@ -44,7 +44,7 @@ public class FastDatePrinterTimeZonesTest {
return timeZones;
}
- private TimeZone timeZone;
+ private final TimeZone timeZone;
public FastDatePrinterTimeZonesTest(TimeZone timeZone) {
this.timeZone = timeZone;