[GitHub] [spark] LuciferYang commented on pull request #29598: [SPARK-32755][SQL] Maintain the order of expressions in AttributeSet and ExpressionSet

[GitBox <gi...@apache.org>]

LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688615468


   Sorry to leave a message in a completed issue. @cloud-fan @dbaliafroozeh This patch seems to bring about some different behavior between use Scala 2.12 and Scala 2.13.
   
   I found that the number of failed cases increased with this patch of the sub-suites of  `PlanStabilitySuite`.
   
   For example, if we execute 
   
   ```
   mvn clean test -pl sql/core -Dtest=none -DwildcardSuites=org.apache.spark.sql.TPCDSV2_7_PlanStabilitySuite -Pscala-2.13 -am 
   ```
   
   The test result with out this patch is 
   
   ```
   Tests: succeeded 32, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```
   
   and with this patch is 
   
   ```
   Tests: succeeded 1, failed 31, canceled 0, ignored 0, pending 0
   *** 31 TESTS FAILED ***
   ```
   
   I haven't found the root cause yet. Do you have any good ideas for fix this problems?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org