You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/12 16:45:00 UTC
[jira] [Commented] (SAMZA-1615) Fix a couple of issues in
ControlMessageSender
[ https://issues.apache.org/jira/browse/SAMZA-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395487#comment-16395487 ]
ASF GitHub Bot commented on SAMZA-1615:
---------------------------------------
GitHub user xinyuiscool opened a pull request:
https://github.com/apache/samza/pull/444
SAMZA-1615: Fix a couple of issues in ControlMessageSender
Two issues I found during testing: 1) medaDataCache.getSystemStreamMetadata(): if we pass in partitionOnly to be true, it will actually not store the metadata into the cache, resulting every call being another query to kafka. I turned off the partitionOnly in order to make it in the cache. 2) change the log for info to debug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinyuiscool/samza SAMZA-1615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit c92a2c66458545ed6903ca75ab6751bc6a85cd8d
Author: xinyuiscool <xi...@...>
Date: 2018-03-12T16:41:14Z
SAMZA-1615: Fix a couple of issues in ControlMessageSender
----
> Fix a couple of issues in ControlMessageSender
> -----------------------------------------------
>
> Key: SAMZA-1615
> URL: https://issues.apache.org/jira/browse/SAMZA-1615
> Project: Samza
> Issue Type: Bug
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Major
>
> Two issues I found during testing:
> 1) medaDataCache.getSystemStreamMetadata(): if we pass in partitionOnly to be true, it will actually not store the metadata into the cache, resulting every call being another query to kafka. I turned off the partitionOnly in order to make it in the cache.
> 2) change the log for info to debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)