You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/06/08 17:08:45 UTC
[GitHub] [daffodil-vscode] shanedell opened a new pull request, #655: Always export env variables
shanedell opened a new pull request, #655:
URL: https://github.com/apache/daffodil-vscode/pull/655
Always export env variables
- Close any opened daffodil-debugger terminal by default.
- This makes sure any env we rely on get set every time a new debug is ran.
Closes #652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #655: Always export env variables
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #655:
URL: https://github.com/apache/daffodil-vscode/pull/655#issuecomment-1584750807
@mbeckerle @scholarsmate The new update fixes the issues where if `DAFFODIL_DEBUG_CLASSPATH` was already set in some other way it wasn't being overriden. This was because the VSCode API method `createTerminal` doesn't seem to overwrite env variables when you specify `env: env`. So to get around it I have the code loop over all env variables and manually set them before running the debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell merged pull request #655: Always export env variables
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #655:
URL: https://github.com/apache/daffodil-vscode/pull/655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #655: Always export env variables
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #655:
URL: https://github.com/apache/daffodil-vscode/pull/655#issuecomment-1584723204
@scholarsmate Whenever a new terminal is created it sets `env: env`. So the change is pretty simple, by default we always destroy any old debugger terminal and make a new terminal. This will make it so the env variables we want to set are being set before the debugger is ran. I am still testing an issue where when I set the `DAFFODIL_DEBUG_CLASSPATH` inside of my `.bashrc` or `.zshrc` it is not being override but creating a new terminal before each debug will be vital in fixing the issue I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org