You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/29 09:56:10 UTC

[GitHub] [camel] essobedo opened a new pull request, #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

essobedo opened a new pull request, #8794:
URL: https://github.com/apache/camel/pull/8794

   Fix https://issues.apache.org/jira/browse/CAMEL-18764 (part 2)
   
   ## Motivation
   
   The first fix allowing to build a templated route from a template defined using a different DSL, makes [several tests fail](https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/810/testReport/) that should be fixed:
   
   * org.apache.camel.cdi.templatedroute.TemplatedRouteTest.sendMessageToInbound
   * org.apache.camel.component.kamelet.TemplatedRouteKameletTest.testKamelet
   * org.apache.camel.dsl.yaml.TemplatedRouteTest.create templated route
   * org.apache.camel.dsl.yaml.TemplatedRouteTest.create templated-route
   
   ## Modifications:
   
   * Add missing calls to the new method `addTemplatedRoutes` ensuring that it is called once all the route templates are added to the context
   * Add a unit test ensuring that the bug is really fixed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #8794:
URL: https://github.com/apache/camel/pull/8794#issuecomment-1330368628

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #8794:
URL: https://github.com/apache/camel/pull/8794#issuecomment-1330446085

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 2 | 2 | 2 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo merged pull request #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

Posted by GitBox <gi...@apache.org>.

essobedo merged PR #8794:
URL: https://github.com/apache/camel/pull/8794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #8794:
URL: https://github.com/apache/camel/pull/8794#issuecomment-1330747179

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 2 | 2 | 1 | 2 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #8794: CAMEL-18764: camel-core - Add unit test and fix regressions

Posted by GitBox <gi...@apache.org>.

essobedo commented on PR #8794:
URL: https://github.com/apache/camel/pull/8794#issuecomment-1330803234

   The remaining test failures are not related to these changes but more to flaky tests in core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org