[GitHub] incubator-carbondata pull request #139: [CARBONDATA-224]Fixed data mismatch ...

[gvramana <gi...@git.apache.org>]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/139#discussion_r77947424
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -864,8 +864,8 @@ class CarbonSqlParser()
        /**
         * detects whether double or decimal column is part of dictionary_exclude
         */
    -  def isDoubleDecimalColDictionaryExclude(columnDataType: String): Boolean = {
    -    val dataTypes = Array("double", "decimal")
    +  def isNumberInColDictionaryExclude(columnDataType: String): Boolean = {
    +     val dataTypes = Array("double", "decimal", "int")
    --- End diff --
    
    Add a reverse check that only string or (varchar-check) is only supported. As other datatypes like bigint etc will have problem in above check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---