You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/08/22 14:54:31 UTC
[GitHub] [beam] damccorm opened a new pull request, #28094: Revert "[Python]Don't stage beam SDK in Stager"
damccorm opened a new pull request, #28094:
URL: https://github.com/apache/beam/pull/28094
Reverts apache/beam#27436
This is causing issues in RC validation (addresses #28084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
URL: https://github.com/apache/beam/pull/28094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28094:
URL: https://github.com/apache/beam/pull/28094#issuecomment-1688373343
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28094?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28094](https://app.codecov.io/gh/apache/beam/pull/28094?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ace89c9) into [master](https://app.codecov.io/gh/apache/beam/commit/a46a35b52fc145649312ebfa4801d0784dd807ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a46a35b) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #28094 +/- ##
==========================================
+ Coverage 72.30% 72.32% +0.01%
==========================================
Files 678 678
Lines 99775 99759 -16
==========================================
+ Hits 72147 72148 +1
+ Misses 26065 26047 -18
- Partials 1563 1564 +1
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28094/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/28094/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.69% <ø> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/28094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://app.codecov.io/gh/apache/beam/pull/28094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.53% <ø> (ø)` | |
| [...s/python/apache\_beam/runners/portability/stager.py](https://app.codecov.io/gh/apache/beam/pull/28094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXIucHk=) | `84.22% <ø> (-0.17%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28094/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28094:
URL: https://github.com/apache/beam/pull/28094#issuecomment-1688351240
R: @tvalentyn @AnandInguva @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28094:
URL: https://github.com/apache/beam/pull/28094#issuecomment-1688357039
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #28094:
URL: https://github.com/apache/beam/pull/28094#issuecomment-1688456845
discussed offline, working on a simple fix-forward CL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28094:
URL: https://github.com/apache/beam/pull/28094#issuecomment-1688491356
(leaving open in case there are issues with the forward fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #28094: Revert "[Python]Don't stage beam SDK in Stager"
URL: https://github.com/apache/beam/pull/28094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org