You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2017/06/09 22:18:52 UTC
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/615
METRON-995: Temporary variables in stellar enrichments which are maps do not function as expected
## Contributor Comments
If you construct a variable which returns a map in a stellar enrichment, it is not able to be used in statements afterwards due to the fact that we explode the map.
For instance, an enrichment like so:
```
foo := { 'foo' : 7}
foo_num := MAP_GET('foo', foo)
foo := null
```
would yield the following fields:
* `foo.foo == 7`
* `foo_num := null`
What we would prefer is just `foo_num == 7` because we've explicitly set the map variable to `null` and removed it. As a policy, we should only explode the fields which are maps that are around at the end of the enrichments. Also, the map itself should be available to be used in downstream enrichments.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron stellar_debug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #615
----
commit 8f13490aaa687f3db9cb682bd2c9b06944334fc5
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T20:43:24Z
Fixed bug with intermediate map variables.
commit 114615de71d92d9828138f33b93b0780ecde4c85
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T21:31:58Z
fixed temporary variable with default group bug.
commit 16fe6c4b974787d3bdf7dd4b302212b8cffba5cb
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T22:09:23Z
Better unit tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #615: METRON-995: Temporary variables in stellar enrichments wh...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/615
+1 by inspection, this is important to have working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
Posted by cestella <gi...@git.apache.org>.
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/615
METRON-995: Temporary variables in stellar enrichments which are maps do not function as expected
## Contributor Comments
If you construct a variable which returns a map in a stellar enrichment, it is not able to be used in statements afterwards due to the fact that we explode the map.
For instance, an enrichment like so:
```
foo := { 'foo' : 7}
foo_num := MAP_GET('foo', foo)
foo := null
```
would yield the following fields:
* `foo.foo == 7`
* `foo_num := null`
What we would prefer is just `foo_num == 7` because we've explicitly set the map variable to `null` and removed it. As a policy, we should only explode the fields which are maps that are around at the end of the enrichments. Also, the map itself should be available to be used in downstream enrichments.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron stellar_debug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #615
----
commit 8f13490aaa687f3db9cb682bd2c9b06944334fc5
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T20:43:24Z
Fixed bug with intermediate map variables.
commit 114615de71d92d9828138f33b93b0780ecde4c85
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T21:31:58Z
fixed temporary variable with default group bug.
commit 16fe6c4b974787d3bdf7dd4b302212b8cffba5cb
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T22:09:23Z
Better unit tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
Posted by cestella <gi...@git.apache.org>.
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
Posted by cestella <gi...@git.apache.org>.
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #615: METRON-995: Temporary variables in stellar enrichments wh...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/615
+1 by inspection, thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #615: METRON-995: Temporary variables in stellar enrichm...
Posted by cestella <gi...@git.apache.org>.
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/615
METRON-995: Temporary variables in stellar enrichments which are maps do not function as expected
## Contributor Comments
If you construct a variable which returns a map in a stellar enrichment, it is not able to be used in statements afterwards due to the fact that we explode the map.
For instance, an enrichment like so:
```
foo := { 'foo' : 7}
foo_num := MAP_GET('foo', foo)
foo := null
```
would yield the following fields:
* `foo.foo == 7`
* `foo_num := null`
What we would prefer is just `foo_num == 7` because we've explicitly set the map variable to `null` and removed it. As a policy, we should only explode the fields which are maps that are around at the end of the enrichments. Also, the map itself should be available to be used in downstream enrichments.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron stellar_debug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #615
----
commit 8f13490aaa687f3db9cb682bd2c9b06944334fc5
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T20:43:24Z
Fixed bug with intermediate map variables.
commit 114615de71d92d9828138f33b93b0780ecde4c85
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T21:31:58Z
fixed temporary variable with default group bug.
commit 16fe6c4b974787d3bdf7dd4b302212b8cffba5cb
Author: cstella <ce...@gmail.com>
Date: 2017-06-09T22:09:23Z
Better unit tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---