You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2007/10/11 15:06:50 UTC
[jira] Created: (HADOOP-2031) Lost tasktracker not handled properly
leading to tips wrongly being kept as completed, and hence not rescheduled
Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
----------------------------------------------------------------------------------------------------------------
Key: HADOOP-2031
URL: https://issues.apache.org/jira/browse/HADOOP-2031
Project: Hadoop
Issue Type: Bug
Components: mapred
Affects Versions: 0.15.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Blocker
Fix For: 0.15.0
The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2031) Lost tasktracker not handled properly
leading to tips wrongly being kept as completed, and hence not rescheduled
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2031:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Devaraj!
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2031) Lost tasktracker not handled
properly leading to tips wrongly being kept as completed, and hence not
rescheduled
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534142 ]
Arun C Murthy commented on HADOOP-2031:
---------------------------------------
+1
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2031) Lost tasktracker not handled
properly leading to tips wrongly being kept as completed, and hence not
rescheduled
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534066 ]
Hadoop QA commented on HADOOP-2031:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12367569/2031.patch
against trunk revision r583424.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/925/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/925/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/925/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/925/console
This message is automatically generated.
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2031) Lost tasktracker not handled properly
leading to tips wrongly being kept as completed, and hence not rescheduled
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-2031:
--------------------------------
Status: Patch Available (was: Open)
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2031) Lost tasktracker not handled properly
leading to tips wrongly being kept as completed, and hence not rescheduled
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-2031:
--------------------------------
Attachment: 2031.patch
Attached patch will fix the problem
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2031) Lost tasktracker not handled
properly leading to tips wrongly being kept as completed, and hence not
rescheduled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534332 ]
Hudson commented on HADOOP-2031:
--------------------------------
Integrated in Hadoop-Nightly #269 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/269/])
> Lost tasktracker not handled properly leading to tips wrongly being kept as completed, and hence not rescheduled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2031
> URL: https://issues.apache.org/jira/browse/HADOOP-2031
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: 2031.patch
>
>
> The TIP.isComplete(taskid) checks for TaskStatus.state being SUCCEEDED and this is used to determine whether this taskid took the TIP to completion. Since, the taskstatus for a KILLED task would have the state as KILLED, this check would fail and hence the TIP would never be marked incomplete. The right solution is to maintain the successful taskid and use that in TIP.isComplete(taskid). This bug got introduced in the last patch for HADOOP-1874.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.