You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mime4j-dev@james.apache.org by mw...@apache.org on 2009/08/17 15:49:39 UTC
svn commit: r804984 -
/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Author: mwiederkehr
Date: Mon Aug 17 13:49:38 2009
New Revision: 804984
URL: http://svn.apache.org/viewvc?rev=804984&view=rev
Log:
renamed decodeBaseQuotedPrintable() in decodeQuotedPrintable()
Modified:
james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java?rev=804984&r1=804983&r2=804984&view=diff
==============================================================================
--- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java (original)
+++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java Mon Aug 17 13:49:38 2009
@@ -40,7 +40,7 @@
* @param s the string to decode.
* @return the decoded bytes.
*/
- public static byte[] decodeBaseQuotedPrintable(String s) {
+ public static byte[] decodeQuotedPrintable(String s) {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
try {
@@ -134,7 +134,7 @@
}
}
- return new String(decodeBaseQuotedPrintable(sb.toString()), charset);
+ return new String(decodeQuotedPrintable(sb.toString()), charset);
}
/**
Re: svn commit: r804984 - /james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Posted by Norman Maurer <no...@apache.org>.
Ok, just wanted to get sure..
Bye,
Norman
2009/8/17 Markus Wiederkehr <ma...@gmail.com>:
> Mime4j is still unstable so I think this should not be a problem.
>
> With 0.6 we (Robert and I mainly) decided that it is okay to break an
> existing API as long as it is broken thoroughly (causes a compile
> error). Not sure what the policy should be for 0.7 though.
>
> Of course we can deprecate the method if you prefer.
>
> Markus
>
> On Mon, Aug 17, 2009 at 3:57 PM, Norman Maurer<no...@apache.org> wrote:
>> I'm not sure this is a good idea .. How about adding a @deprecated
>> annotation and remove it later..
>>
>> Bye,
>> Norman
>>
>> 2009/8/17 <mw...@apache.org>:
>>> Author: mwiederkehr
>>> Date: Mon Aug 17 13:49:38 2009
>>> New Revision: 804984
>>>
>>> URL: http://svn.apache.org/viewvc?rev=804984&view=rev
>>> Log:
>>> renamed decodeBaseQuotedPrintable() in decodeQuotedPrintable()
>>>
>>> Modified:
>>> james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
>>>
>>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
>>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java?rev=804984&r1=804983&r2=804984&view=diff
>>> ==============================================================================
>>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java (original)
>>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java Mon Aug 17 13:49:38 2009
>>> @@ -40,7 +40,7 @@
>>> * @param s the string to decode.
>>> * @return the decoded bytes.
>>> */
>>> - public static byte[] decodeBaseQuotedPrintable(String s) {
>>> + public static byte[] decodeQuotedPrintable(String s) {
>>> ByteArrayOutputStream baos = new ByteArrayOutputStream();
>>>
>>> try {
>>> @@ -134,7 +134,7 @@
>>> }
>>> }
>>>
>>> - return new String(decodeBaseQuotedPrintable(sb.toString()), charset);
>>> + return new String(decodeQuotedPrintable(sb.toString()), charset);
>>> }
>>>
>>> /**
>>>
>>>
>>>
>>
>
>
>
> --
> Always remember you're unique. Just like everyone else.
>
Re: svn commit: r804984 - /james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Mon, Aug 17, 2009 at 3:07 PM, Markus
Wiederkehr<ma...@gmail.com> wrote:
> Mime4j is still unstable so I think this should not be a problem.
>
> With 0.6 we (Robert and I mainly) decided that it is okay to break an
> existing API as long as it is broken thoroughly (causes a compile
> error). Not sure what the policy should be for 0.7 though.
i'm comfortable with continuing to allow the API to develop
IMHO we should start making more efforts to ensure that changes are
clearly documented in the release notes, though
- robert
Re: svn commit: r804984 - /james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Posted by Markus Wiederkehr <ma...@gmail.com>.
Mime4j is still unstable so I think this should not be a problem.
With 0.6 we (Robert and I mainly) decided that it is okay to break an
existing API as long as it is broken thoroughly (causes a compile
error). Not sure what the policy should be for 0.7 though.
Of course we can deprecate the method if you prefer.
Markus
On Mon, Aug 17, 2009 at 3:57 PM, Norman Maurer<no...@apache.org> wrote:
> I'm not sure this is a good idea .. How about adding a @deprecated
> annotation and remove it later..
>
> Bye,
> Norman
>
> 2009/8/17 <mw...@apache.org>:
>> Author: mwiederkehr
>> Date: Mon Aug 17 13:49:38 2009
>> New Revision: 804984
>>
>> URL: http://svn.apache.org/viewvc?rev=804984&view=rev
>> Log:
>> renamed decodeBaseQuotedPrintable() in decodeQuotedPrintable()
>>
>> Modified:
>> james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
>>
>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java?rev=804984&r1=804983&r2=804984&view=diff
>> ==============================================================================
>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java (original)
>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java Mon Aug 17 13:49:38 2009
>> @@ -40,7 +40,7 @@
>> * @param s the string to decode.
>> * @return the decoded bytes.
>> */
>> - public static byte[] decodeBaseQuotedPrintable(String s) {
>> + public static byte[] decodeQuotedPrintable(String s) {
>> ByteArrayOutputStream baos = new ByteArrayOutputStream();
>>
>> try {
>> @@ -134,7 +134,7 @@
>> }
>> }
>>
>> - return new String(decodeBaseQuotedPrintable(sb.toString()), charset);
>> + return new String(decodeQuotedPrintable(sb.toString()), charset);
>> }
>>
>> /**
>>
>>
>>
>
--
Always remember you're unique. Just like everyone else.
Re: svn commit: r804984 - /james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
Posted by Norman Maurer <no...@apache.org>.
I'm not sure this is a good idea .. How about adding a @deprecated
annotation and remove it later..
Bye,
Norman
2009/8/17 <mw...@apache.org>:
> Author: mwiederkehr
> Date: Mon Aug 17 13:49:38 2009
> New Revision: 804984
>
> URL: http://svn.apache.org/viewvc?rev=804984&view=rev
> Log:
> renamed decodeBaseQuotedPrintable() in decodeQuotedPrintable()
>
> Modified:
> james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
>
> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java
> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java?rev=804984&r1=804983&r2=804984&view=diff
> ==============================================================================
> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java (original)
> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/codec/DecoderUtil.java Mon Aug 17 13:49:38 2009
> @@ -40,7 +40,7 @@
> * @param s the string to decode.
> * @return the decoded bytes.
> */
> - public static byte[] decodeBaseQuotedPrintable(String s) {
> + public static byte[] decodeQuotedPrintable(String s) {
> ByteArrayOutputStream baos = new ByteArrayOutputStream();
>
> try {
> @@ -134,7 +134,7 @@
> }
> }
>
> - return new String(decodeBaseQuotedPrintable(sb.toString()), charset);
> + return new String(decodeQuotedPrintable(sb.toString()), charset);
> }
>
> /**
>
>
>