[GitHub] [arrow-rs] viirya commented on a diff in pull request #4349: Don't infer 16-byte decimal as decimal256

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #4349:
URL: https://github.com/apache/arrow-rs/pull/4349#discussion_r1214607088


##########
parquet/src/arrow/schema/primitive.rs:
##########
@@ -285,14 +285,14 @@ fn from_fixed_len_byte_array(
     // TODO: This should check the type length for the decimal and interval types
     match (info.logical_type(), info.converted_type()) {
         (Some(LogicalType::Decimal { scale, precision }), _) => {
-            if type_length < 16 {
+            if type_length <= 16 {

Review Comment:
   Nice catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org