[GitHub] [iceberg] rdblue commented on a diff in pull request #5237: API: Add IcebergBuild info

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5237:
URL: https://github.com/apache/iceberg/pull/5237#discussion_r917453696


##########
build.gradle:
##########
@@ -45,15 +45,6 @@ plugins {
 try {
   // apply these plugins in a try-catch block so that we can handle cases without .git directory
   apply plugin: 'com.palantir.git-version'
-  apply plugin: 'com.gorylenko.gradle-git-properties'
-  // git properties file for the root project for adding to the source tarball
-  gitProperties {
-    gitPropertiesName = 'iceberg-build.properties'
-    gitPropertiesResourceDir = file("${rootDir}/build")
-    extProperty = 'gitProps'
-    failOnNoGitDirectory = true
-  }
-  generateGitProperties.outputs.upToDateWhen { false }

Review Comment:
   This is moved out of the try/catch block because it is safe to add the plugin when `.git` is not present. The `fialOnNoGitDirectory` flag determines whether `generateGitProperties` will succeed if it isn't present. It is set to true here because the build should fail if there is no root `iceberg-build.properties` file and `.git` is not present.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org