[GitHub] [netbeans] OndroMih commented on issue #5676: Java DB drivers are not referencing correct Derby classes

["OndroMih (via GitHub)" <gi...@apache.org>]

OndroMih commented on issue #5676:
URL: https://github.com/apache/netbeans/issues/5676#issuecomment-1566121251

   It looks like that the driver classes were moved to a new JAR `lib/derbytools.jar`. This JAR needs to be added to both Java DB Network and Embedded configurations. I think they need to be added in these 2 places:
   
   * https://github.com/apache/netbeans/blob/711207c11ba278c94b05d931ebd5fdc3a4b55d9f/ide/derby/src/org/netbeans/modules/derby/DerbyOptions.java#L253 - to register the drivers with this additional JAR
   * https://github.com/apache/netbeans/blob/711207c11ba278c94b05d931ebd5fdc3a4b55d9f/ide/derby/src/org/netbeans/modules/derby/DerbyDatabasesImpl.java#L545 - to add this additional JAR to the DbURLClassLoader to load the driver class. This is used during creation of a new DB
   
   I'm willing to submit a pull request when I have some time, but I won't be able to get to this in the following weeks. @DiskCrasher , if you'd like to submit a PR, go for it. I hope that with my advice, it should be pretty straightforward to fix this. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists