You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/24 16:57:04 UTC

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8230: drivers/camera: Support the private data for imgsensor and imgdata

xiaoxiang781216 opened a new pull request, #8230:
URL: https://github.com/apache/nuttx/pull/8230

   ## Summary
   Make video driver model close other driver framework and support the multiple instances from one driver.
   
   ## Impact
   video capture
   
   ## Testing
   
   sim:camera and spresense:camera


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8230:
URL: https://github.com/apache/nuttx/pull/8230#discussion_r1087629514


##########
include/nuttx/video/imgsensor.h:
##########
@@ -265,7 +294,7 @@ typedef struct imgsensor_capability_range_s
 typedef struct imgsensor_capability_discrete_s
 {
   int8_t  nr_values;
-  int32_t *values;
+  const int32_t *values;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] jerpelea merged pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata

Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #8230:
URL: https://github.com/apache/nuttx/pull/8230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8230:
URL: https://github.com/apache/nuttx/pull/8230#discussion_r1087178477


##########
include/nuttx/video/imgsensor.h:
##########
@@ -265,7 +294,7 @@ typedef struct imgsensor_capability_range_s
 typedef struct imgsensor_capability_discrete_s
 {
   int8_t  nr_values;
-  int32_t *values;
+  const int32_t *values;

Review Comment:
   ```suggestion
     FAR const int32_t *values;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis commented on pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8230:
URL: https://github.com/apache/nuttx/pull/8230#issuecomment-1404065201

   @masayuki2009 @jerpelea does Spresence camera still working after this modification?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] SPRESENSE commented on pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata

Posted by "SPRESENSE (via GitHub)" <gi...@apache.org>.
SPRESENSE commented on PR #8230:
URL: https://github.com/apache/nuttx/pull/8230#issuecomment-1409699133

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org