You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/25 04:57:17 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request #1788: [ISSUE
#1787] Fix the issue that queryCq command of mqadmin returned incorrect data
RongtongJin opened a new pull request #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788
## What is the purpose of the change
Fix #1787
## Brief changelog
Set the result after the query
## Verifying this change
Verified in my pc
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin closed pull request #1788: [ISSUE #1787] Fix
the issue that queryCq command of mqadmin returned incorrect data
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1788:
[ISSUE #1787] Fix the issue that queryCq command of mqadmin returned
incorrect data
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on a change in pull request #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788#discussion_r384554868
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -1556,7 +1553,8 @@ private RemotingCommand queryConsumeQueue(ChannelHandlerContext ctx,
} finally {
result.release();
}
-
+ response.setCode(ResponseCode.SUCCESS);
Review comment:
It would be better not to move response.setcode (ResponseCode.SUCCESS); because when the result is null, this method will return a Response without a status code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1788: [ISSUE #1787] Fix
the issue that queryCq command of mqadmin returned incorrect data
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788#issuecomment-590688814
[](https://coveralls.io/builds/28938176)
Coverage decreased (-0.006%) to 50.929% when pulling **306aab9ee0944e0d7ed71c6cb56c7723b43ba107 on RongtongJin:fix_1787** into **73bb4b402a5da02faf9feded8f4d79dd1ba88348 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin commented on issue #1788: [ISSUE #1787] Fix
the issue that queryCq command of mqadmin returned incorrect data
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788#issuecomment-591851487
I found that I submitted this pr to master branch, so I will resubmit a pr to fix this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services