You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/09 13:25:06 UTC
[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #6740: Add more test cases for TypedSPIRegistry‘s exception occur
jacksparrow414 opened a new pull request #6740:
URL: https://github.com/apache/shardingsphere/pull/6740
Fixes #6732 .
Changes proposed in this pull request:
- Add more test case for TypedSPIRegistry
- Add interface named NoImplTypedSPIFixture
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6740: Add more test cases for TypedSPIRegistry‘s exception occur
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6740:
URL: https://github.com/apache/shardingsphere/pull/6740#issuecomment-671054461
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=h1) Report
> Merging [#6740](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b4363c64d4c594e7dc6e0d8fc9af1855f142fc6c&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6740 +/- ##
============================================
+ Coverage 54.19% 54.23% +0.03%
Complexity 428 428
============================================
Files 1237 1237
Lines 21973 21973
Branches 3954 3954
============================================
+ Hits 11909 11916 +7
+ Misses 9291 9285 -6
+ Partials 773 772 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../metrics/facade/handler/MetricsTrackerHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1tZXRyaWNzL3NoYXJkaW5nc3BoZXJlLW1ldHJpY3MtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tZXRyaWNzL2ZhY2FkZS9oYW5kbGVyL01ldHJpY3NUcmFja2VySGFuZGxlci5qYXZh) | `91.22% <0.00%> (-1.76%)` | `1.00% <0.00%> (ø%)` | |
| [...hardingsphere/infra/spi/type/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/6740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZS9UeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `100.00% <0.00%> (+40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...pi/exception/ServiceProviderNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/6740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvZXhjZXB0aW9uL1NlcnZpY2VQcm92aWRlck5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | `100.00% <0.00%> (+100.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=footer). Last update [b4363c6...32cea03](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #6740: Add more test cases for TypedSPIRegistry‘s exception occur
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6740:
URL: https://github.com/apache/shardingsphere/pull/6740#issuecomment-675233991
## Pull Request Test Coverage Report for [Build 13614](https://coveralls.io/builds/32630865)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.03%**) to **56.366%**
---
| Totals | [](https://coveralls.io/builds/32630865) |
| :-- | --: |
| Change from base [Build 13613](https://coveralls.io/builds/32629803): | 0.03% |
| Covered Lines: | 12702 |
| Relevant Lines: | 22535 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #6740: Add more test cases for TypedSPIRegistry‘s exception occur
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6740:
URL: https://github.com/apache/shardingsphere/pull/6740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #6740: Add more test cases for TypedSPIRegistry‘s exception occur
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #6740:
URL: https://github.com/apache/shardingsphere/pull/6740#issuecomment-671054461
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=h1) Report
> Merging [#6740](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b4363c64d4c594e7dc6e0d8fc9af1855f142fc6c&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6740 +/- ##
============================================
+ Coverage 54.19% 54.23% +0.03%
Complexity 428 428
============================================
Files 1237 1237
Lines 21973 21973
Branches 3954 3954
============================================
+ Hits 11909 11917 +8
+ Misses 9291 9285 -6
+ Partials 773 771 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hardingsphere/infra/spi/type/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/6740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZS9UeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `100.00% <0.00%> (+40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...pi/exception/ServiceProviderNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/6740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvZXhjZXB0aW9uL1NlcnZpY2VQcm92aWRlck5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | `100.00% <0.00%> (+100.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=footer). Last update [b4363c6...32cea03](https://codecov.io/gh/apache/shardingsphere/pull/6740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org