You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Apekshit Sharma (JIRA)" <ji...@apache.org> on 2015/07/21 11:03:05 UTC

[jira] [Created] (HBASE-14127) Refactor AssignmentManager.unassign() function which has lots of return statements

Apekshit Sharma created HBASE-14127:
---------------------------------------

             Summary: Refactor AssignmentManager.unassign() function which has lots of return statements
                 Key: HBASE-14127
                 URL: https://issues.apache.org/jira/browse/HBASE-14127
             Project: HBase
          Issue Type: Improvement
            Reporter: Apekshit Sharma
            Assignee: Apekshit Sharma
            Priority: Minor


In AssignmentManager.unassign()
* there are lots of return points
* if condition is very non-trivial to understand
* reuse of 'state' for different purpose makes things confusing

A simple unfold of if-else with with better variable names should be sufficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)