You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Ben Smith (JIRA)" <tu...@ws.apache.org> on 2008/01/16 12:52:37 UTC

[jira] Created: (TUSCANY-1996) ConversationEndedException is not thrown.

ConversationEndedException is not thrown.
-----------------------------------------

                 Key: TUSCANY-1996
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
             Project: Tuscany
          Issue Type: Bug
          Components: Java SCA Core Runtime
    Affects Versions: Java-SCA-1.0.1
         Environment: Revision: 596254
            Reporter: Ben Smith
             Fix For: Java-SCA-Next


ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.

Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1996) ConversationEndedException is not thrown.

Posted by "Ben Smith (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Smith updated TUSCANY-1996:
-------------------------------

    Comment: was deleted

> ConversationEndedException is not thrown.
> -----------------------------------------
>
>                 Key: TUSCANY-1996
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-1.0.1
>         Environment: Revision: 596254
>            Reporter: Ben Smith
>             Fix For: Java-SCA-Next
>
>
> ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.
> Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1996) ConversationEndedException is not thrown.

Posted by "Simon Nash (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559593#action_12559593 ] 

Simon Nash commented on TUSCANY-1996:
-------------------------------------

This behavior is correct for the case of explicitly ending the conversation, but not for the case of the conversation timing out.  The following is from the SCA Java Annotations and APIs 1.00 errata at http://www.osoa.org/display/Main/Errata+for+Java+Annotations+and+APIs+V1.00

5. Resolve contradiction regarding ConversationEndedException

Description: Section 1.6.2.2 @EndsConversation (lines 409-420) states that when a method is called on a conversational interface after an @EndsConversation has been called, a ConversationEndedException is thrown. This contradicts section 1.6.5 Conversation Lifetime Summary / Ending conversations, lines 494-495, where it states that "after an @EndsConversation method has been called" (on a service reference) ", then a new conversation will automatically be started." ...and... (lines 498-499) if the conversation has timed out, a ConversationEndedException is thrown.

Solution: Replace lines 417-420 at the end of section 1.6.2.2 with the following: "If a conversation is ended with an explicit outbound call to an @EndsConversation method or a call to ServiceReference.endConversation(), then any subsequent call to an operation on the service reference will start a new conversation.  If the conversation ends for any other reason (e.g. a timeout occurred), then until ServiceReference.getConversation().end() is called, the ConversationEndedException will be thrown by any conversational operation."



> ConversationEndedException is not thrown.
> -----------------------------------------
>
>                 Key: TUSCANY-1996
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-1.0.1
>         Environment: Revision: 596254
>            Reporter: Ben Smith
>             Fix For: Java-SCA-Next
>
>
> ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.
> Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1996) ConversationEndedException is not thrown.

Posted by "Ben Smith (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559896#action_12559896 ] 

Ben Smith commented on TUSCANY-1996:
------------------------------------

I am working on a patch for this issue. Will take into account Simons comments and ensure that the exception is thrown on expired conversations. 

With regards to conversations that have have ended through an @EndsConversations method I have noticed that if it uses a System generated Conversation ID it will reuse this ID. Should it not instead create a new one?

Ben

> ConversationEndedException is not thrown.
> -----------------------------------------
>
>                 Key: TUSCANY-1996
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-1.0.1
>         Environment: Revision: 596254
>            Reporter: Ben Smith
>             Fix For: Java-SCA-Next
>
>
> ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.
> Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1996) ConversationEndedException is not thrown.

Posted by "Ben Smith (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Smith resolved TUSCANY-1996.
--------------------------------

    Resolution: Invalid

> ConversationEndedException is not thrown.
> -----------------------------------------
>
>                 Key: TUSCANY-1996
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-1.0.1
>         Environment: Revision: 596254
>            Reporter: Ben Smith
>             Fix For: Java-SCA-Next
>
>
> ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.
> Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1996) ConversationEndedException is not thrown.

Posted by "Ben Smith (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559897#action_12559897 ] 

Ben Smith commented on TUSCANY-1996:
------------------------------------

OK... I'm happy that this is has been fixed previously


> ConversationEndedException is not thrown.
> -----------------------------------------
>
>                 Key: TUSCANY-1996
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1996
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-1.0.1
>         Environment: Revision: 596254
>            Reporter: Ben Smith
>             Fix For: Java-SCA-Next
>
>
> ConversationEndedException is not thrown if you reuse a service after you have ended the conversation or the conversation has expired. Instead it starts a new conversation with the same conversation id.  This can be seen in the conversationPreInvoke method in the JDKInvocationHandler. Where conversations are re-used even if they are in the ended state.
> Ben

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org