You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 18:07:10 UTC

[GitHub] [beam] ryanthompson591 commented on a change in pull request #15472: Add cloudpickle as optional library

ryanthompson591 commented on a change in pull request #15472:
URL: https://github.com/apache/beam/pull/15472#discussion_r742207492



##########
File path: sdks/python/apache_beam/coders/coders_test_common.py
##########
@@ -680,14 +682,14 @@ def iterable_state_read(token, element_coder_impl):
     context = pipeline_context.PipelineContext(
         iterable_state_read=iterable_state_read,
         iterable_state_write=iterable_state_write)
-    self.check_coder(
-        coder, [1, 2, 3], context=context, test_size_estimation=False)
+    # Note: do not use check_coder see https://github.com/cloudpipe/cloudpickle/issues/452

Review comment:
       Yes, this will fail for pipelines that use logic similar to this test with cloudpickle. That is to say a global variable.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org