You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/25 13:19:34 UTC

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5663: TP: Update GHA to run new TP tests

shamrickus commented on a change in pull request #5663:
URL: https://github.com/apache/trafficcontrol/pull/5663#discussion_r601477043



##########
File path: .github/workflows/tp.integration.tests.yml
##########
@@ -90,27 +92,33 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@master
-      - name: Cache Alpine Docker image
-        uses: actions/cache@v2
-        with:
-          path: ${{ github.workspace }}/docker-images
-          key: docker-images/alpine@${{ env.ALPINE_VERSION }}.tar.gz
-      - name: Import cached Alpine Docker image
-        run: .github/actions/save-alpine-tar/entrypoint.sh load ${{ env.ALPINE_VERSION }}
-      - name: Cache node modules
-        uses: actions/cache@v2
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-modules-${{ hashFiles('traffic_portal/package-lock.json traffic_portal/bower.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-
+#      - name: Cache Alpine Docker image
+#        uses: actions/cache@v2
+#        with:
+#          path: ${{ github.workspace }}/docker-images
+#          key: docker-images/alpine@${{ env.ALPINE_VERSION }}.tar.gz
+#      - name: Import cached Alpine Docker image
+#        run: .github/actions/save-alpine-tar/entrypoint.sh load ${{ env.ALPINE_VERSION }}
+#      - name: Cache node modules
+#        uses: actions/cache@v2
+#        with:
+#          path: ~/.npm
+#          key: ${{ runner.os }}-node-modules-${{ hashFiles('traffic_portal/package-lock.json traffic_portal/bower.json') }}
+#          restore-keys: |
+#            ${{ runner.os }}-node-modules-

Review comment:
       Meant to uncomment this before I PR'd.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org