You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/05/17 07:28:51 UTC

[GitHub] [mesos] asekretenko edited a comment on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).

asekretenko edited a comment on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959


   @cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact kernel version introduced them, please check that). Otherwise, looks good to me. 
   
   Great that you caught this before releasing this code! Otherwise, this rename in `proto`s would be potentially breaking users of json APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org