You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/04/11 22:09:35 UTC

[GitHub] [madlib] jingyimei opened a new pull request #367: DL: Remove reshaping

jingyimei opened a new pull request #367: DL: Remove reshaping
URL: https://github.com/apache/madlib/pull/367
 
 
   This PR does the following:
   1. Add a simple validation check to fit() that input shape = model architecture expected shape.
   2. Do not re-shape image inputs both for training data and validation data
   3. Add numeric array check to dependent var for validation table
   4. Rename helper class/file to validator
   5. Use FORMAT class for getting model_arch col names(previously it was hardcoded, which caused discrepancy between minibatch_preprocessor_dl() and madlib_keras_fit()).
   6. Update dev check and unit test(also move all unit tests to madlib_keras.py_in)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services