You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Senaka Fernando (JIRA)" <ji...@apache.org> on 2008/02/14 16:51:08 UTC
[jira] Issue Comment Edited: (AXIS2C-573) Fix warnings on windows
[ https://issues.apache.org/jira/browse/AXIS2C-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568973#action_12568973 ]
senakafdo edited comment on AXIS2C-573 at 2/14/08 7:50 AM:
-----------------------------------------------------------------
I have attached a modified list of 20 remaining warnings (TXT, XLS, and RTF) when I build with /W4, which is apparently the highest. I hope we can get rid of these few forever. Note the information below.
1. I have specifically disabled C4100, which can't be avoided due to our coding convention. This is due to un-used formal parameters.
2. I have modified AXIS2_HASH_KEY_STRING (-1), as AXIS2_HASH_KEY_STRING (unsigned int)(-1)
3. We must get rid of those remaining casts of function pointers to void *, as it can be a really big issue on a later date as in [1].
4. We do have some unreachable code (2 places). Better have a good look on these. I did not go to alter these, as, I am not aware of any complication that may crop up as a result.
5. I did build as C code this time and got to replace those deprecated POSIX stuff.
I believe that there is only little more work left to close this JIRA. This fixes should not have any side effects on other sub projects and I have tested it with WSF/C on Windows. If there are any issues, as a result of this fix, that I did not notice, please let me know so that I can help you get them straight.
[1] http://www.thescripts.com/forum/thread567535.html
Regards,
Senaka
was (Author: senakafdo):
I have attached a modified list of 20 remaining warnings (TXT, XLS, and RTF) when I build with /W4, which is apparently the highest. I hope we can get rid of these few forever. Note the information below.
1. I have specifically disabled C4100, which can't be avoided due to our coding convention. This is due to un-used formal parameters.
2. I have modified AXIS2_HASH_KEY_STRING (-1), as AXIS2_HASH_KEY_STRING (unsigned int)(-1)
3. We must get rid of those remaining casts of function pointers to void *, as it can be a really big issue on a later date as in [1].
4. We do have some unreachable code (2 places). Better have a good look on these. I did not go to alter these, as, I am not aware of any complication that may crop up as a result.
5. I did build as C code this time and goto replace those deprecated POSIX stuff.
I believe that there is only little more work left to close this JIRA. This fixes should not have any side effects on other sub projects and I have tested it with WSF/C on Windows. If there are any issues, as a result of this fix, that I did not notice, please let me know so that I can help you get them straight.
[1] http://www.thescripts.com/forum/thread567535.html
Regards,
Senaka
> Fix warnings on windows
> ------------------------
>
> Key: AXIS2C-573
> URL: https://issues.apache.org/jira/browse/AXIS2C-573
> Project: Axis2-C
> Issue Type: Bug
> Components: build system (Windows)
> Environment: Windows
> Reporter: Nandika Jayawardana
> Assignee: Senaka Fernando
> Fix For: 1.3.0
>
> Attachments: warnings.rtf, warnings.txt, warnings.xls, warnings_2.rtf, warnings_2.txt, warnings_2.xls
>
>
> When building axis2c source on windows, there are large number of warnings. These warnings should be fixed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org