You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "adamdebreceni (via GitHub)" <gi...@apache.org> on 2023/04/27 07:57:18 UTC
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1567: MINIFICPP-2111 - Remove test-only method
adamdebreceni opened a new pull request, #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1193811911
##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########
@@ -456,7 +452,7 @@ Remote Process Groups:
NiFi Properties Overrides: {}
)";
std::istringstream configYamlStream(TEST_CONFIG_YAML);
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1193818426
##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########
Review Comment:
#1566 touches the same file, changed them here as well to see if everything else is ok, but will have to be careful on merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1182739954
##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########
Review Comment:
```
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:162:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
for (auto it : connectionMap) {
^
const &
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:474:13: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
for (auto it : connectionMap) {
^
const &
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:762:13: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
for (auto it : connectionMap) {
^
const &
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1567: MINIFICPP-2111 - Remove test-only method
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1567: MINIFICPP-2111 - Remove test-only method
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1183483569
##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########
@@ -456,7 +452,7 @@ Remote Process Groups:
NiFi Properties Overrides: {}
)";
std::istringstream configYamlStream(TEST_CONFIG_YAML);
Review Comment:
this `configYamlStream` (and the one at line 497) are no longer needed, either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org