[GitHub] [tomcat] michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…
URL: https://github.com/apache/tomcat/pull/225#discussion_r349608794
 
 

 ##########
 File path: java/org/apache/catalina/realm/CombinedRealm.java
 ##########
 @@ -386,6 +387,38 @@ public Principal authenticate(GSSContext gssContext, boolean storeCred) {
         return null;
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public Principal authenticate(GSSName gssName, GSSCredential gssCredential) {
+        Principal authenticatedUser = null;
+        String username = gssName.toString();
 
 Review comment:
   That's true, I have simply reused the current code pattern from others methods to all look alike. This can be cleaned up in `RealmBase` is a distinct subsequent commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org