You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2018/08/25 21:49:40 UTC
[Bug 7603] New: 3.4 and Trunk both currently fail on uribl.t
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
Bug ID: 7603
Summary: 3.4 and Trunk both currently fail on uribl.t
Product: Spamassassin
Version: 3.4 SVN branch
Hardware: PC
OS: Windows NT
Status: NEW
Severity: blocker
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: kmcgrail@apache.org
Target Milestone: Undefined
to recreate the issue, you must copy t/config.dist to t/config and turn on
network tests.
Then running prove -v t/uribl.t will show an error on checking NS
t/uribl.t ..
1..6
/usr/bin/perl -T -w ../spamassassin.raw -C log/test_rules_copy
--siteconfigpath log/localrules.tmp -p log/test_default.cf -t <
data/spam/dnsbl.eml
ok 1
Checking A
ok 2
Checking B
ok 3
Checking X_URIBL_DOMSONLY
ok 4
Checking NS
not ok 5
Checking for anti-pattern FULL_NS at t/uribl.t line 55.
ok 6
Not found: NS = X_URIBL_NS at t/uribl.t line 55.
# Failed test at t/SATest.pm line 783.
Output can be examined in: log/d.uribl/0
# Looks like you failed 1 test of 6.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests
Test Summary Report
-------------------
t/uribl.t (Wstat: 256 Tests: 6 Failed: 1)
Failed test: 5
Non-zero exit status: 1
Files=1, Tests=6, 7 wallclock secs ( 0.03 usr 0.01 sys + 2.49 cusr 0.10
csys = 2.63 CPU)
Result: FAIL
This ALSO fails on 3.4.1 so it's possible the issue is something from the zones
when we switch from Bind to PowerDNS.
In the meantime considering it a blocker.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
--- Comment #6 from Kevin A. McGrail <km...@apache.org> ---
(In reply to Bill Cole from comment #5)
> (In reply to Dave Jones from comment #2)
>
> > Does anyone know what this is supposed to test? Is it just suppose to be a
> > unit test for urinsrhssub?
>
> Yes. The test script t/uribl.t tests the various rule types defined in
> Mail::SpamAssassin::Plugin::URIDNSBL.
>
> > I can easily add these A records to make it
> > start passing.
>
> I've added them via svn but perhaps that's not what is needed?
Bill, DNS is now using powerDNS. Dave, can you assist him with adding records?
It sounds like in general we are just missing a few records when we switched
from Bind to PowerDNS.
That makes me happy to have the issues close to resolution!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
--- Comment #7 from Dave Jones <da...@apache.org> ---
I have added these 2 A records to PowerDNS hosting the spamassassin.org hidden
master.
See https://wiki.apache.org/spamassassin/InfraNotes2017#DNS_Hosting for
details.
The SVN copy is only a record of changes and gets updated once a week by a
script on sa-vm1.apache.org exporting the zone and pushing it back into SVN.
This DNS update is live now:
[djones@djones5 ~]$ dig @ns2.ena.com ena.com.dnsbltest.spamassassin.org +short
127.0.0.8
[djones@djones5 ~]$ dig @ns2.ena.com pccc.com.dnsbltest.spamassassin.org +short
127.0.0.8
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
--- Comment #5 from Bill Cole <sa...@billmail.scconsult.com> ---
(In reply to Dave Jones from comment #2)
> Does anyone know what this is supposed to test? Is it just suppose to be a
> unit test for urinsrhssub?
Yes. The test script t/uribl.t tests the various rule types defined in
Mail::SpamAssassin::Plugin::URIDNSBL.
> I can easily add these A records to make it
> start passing.
I've added them via svn but perhaps that's not what is needed?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
--- Comment #3 from Bill Cole <sa...@billmail.scconsult.com> ---
(In reply to Bill Cole from comment #1)
> I am investigating when, if ever, this has worked and how.
At 3.4.1 release time, the NS records for spamassassin.org were (in
BIND/canonical zonefile form):
@ NS a.auth-ns.sonic.net.
NS b.auth-ns.sonic.net.
NS c.auth-ns.sonic.net.
NS ns.hyperreal.org.
Today they are (in PDNS form):
spamassassin.org 86400 IN NS ns2.ena.com.
spamassassin.org 86400 IN NS ns2.pccc.com.
spamassassin.org 86400 IN NS c.auth-ns.sonic.net.
spamassassin.org 86400 IN NS b.auth-ns.sonic.net.
spamassassin.org 86400 IN NS a.auth-ns.sonic.net.
There is a record in both zones that would have made uribl.t work at 3.4.1
release time:
hyperreal.org.dnsbltest.spamassassin.org. 3600 IN A 127.0.0.8
To make the test work, I have added:
ena.com.dnsbltest.spamassassin.org 3600 IN A 127.0.0.8
pccc.com.org.dnsbltest.spamassassin.org 3600 IN A 127.0.0.8
Commited r1839374
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #8 from Kevin A. McGrail <km...@apache.org> ---
Thanks Dave. This confirms why the test fails. It's still a little
inconsistent but it always was before.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
Dave Jones <da...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |davej@apache.org
--- Comment #2 from Dave Jones <da...@apache.org> ---
When the old SA server went away in early 2017 and I setup the DNS hosting
again on the new sa-vm1.apache.org, I didn't add back those subdomains into
PowerDNS hosting of the hidden master. If it's needed, then I can add back
those records.
The old records didn't make any sense to me at the time. These have not
existed for about a year.
Does anyone know what this is supposed to test? Is it just suppose to be a
unit test for urinsrhssub? I can easily add these A records to make it start
passing.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
--- Comment #4 from Bill Cole <sa...@billmail.scconsult.com> ---
Also updated SOA serial: r1839375
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7603] 3.4 and Trunk both currently fail on uribl.t
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7603
Bill Cole <sa...@billmail.scconsult.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sa-bugz-20080315@billmail.s
| |cconsult.com
--- Comment #1 from Bill Cole <sa...@billmail.scconsult.com> ---
The failure is due to this rule not matching:
urinsrhssub X_URIBL_NS dnsbltest.spamassassin.org. A 8
body X_URIBL_NS eval:check_uridnsbl('X_URIBL_NS')
That results in A queries for:
sonic.net.dnsbltest.spamassassin.org
pccc.com.dnsbltest.spamassassin.org
ena.com.dnsbltest.spamassassin.org
Because none of these is in the current spamassassin.org zone file, that rule
cannot match and the test cannot succeed.
I am investigating when, if ever, this has worked and how.
--
You are receiving this mail because:
You are the assignee for the bug.