You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/24 20:09:01 UTC

[kudu-CR] clients: prefer tservers in the same location when multiple are local

Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15794

to look at the new patch set (#3).

Change subject: clients: prefer tservers in the same location when multiple are local
......................................................................

clients: prefer tservers in the same location when multiple are local

be68ce8 introduced the behavior that mini-servers that are local to a
C++ client are treated as local, even on Linux. As such, a
location-aware mini-cluster would not honor client location awareness,
since all mini-servers would be considered local.

While this surfaced as flakiness of location_awareness-itest, this is an
actual product deficiency, albeit one we don't expect to be very common:
if multiple servers are colocated with a client, and the servers are
assigned different locations, those locations should be honored when
picking tablet servers.

Without this patch, location_assignment-itest is ~24% flaky. With it, it
passed in debug mode 300/300 times.

The same logic is updated in the Java client.

Change-Id: I6a0dbac073ba8a9f80a3f175157a09d06037b0df
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/location_assignment-itest.cc
3 files changed, 25 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/15794/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a0dbac073ba8a9f80a3f175157a09d06037b0df
Gerrit-Change-Number: 15794
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)