You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liuml07 (via GitHub)" <gi...@apache.org> on 2024/11/02 00:09:30 UTC
Re: [PR] Flink: FLIP-27 IcebergSource builder missed a couple of configs compared to old FlinkSource: expose locality and plan parallelism [iceberg]
liuml07 commented on code in PR #10957:
URL: https://github.com/apache/iceberg/pull/10957#discussion_r1826390148
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -482,6 +482,10 @@ public IcebergSource<T> build() {
}
contextBuilder.resolveConfig(table, readOptions, flinkConfig);
+ contextBuilder.exposeLocality(
+ SourceUtil.isLocalityEnabled(table, flinkConfig, exposeLocality));
+ contextBuilder.planParallelism(
Review Comment:
Quick question: I see `contextBuilder.resolveConfig(table, readOptions, flinkConfig)` above already sets the planParallelism via `.planParallelism(flinkReadConf.workerPoolSize())`, is that not sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org