You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-dev@hadoop.apache.org by Roger Hoover <ro...@gmail.com> on 2013/02/21 22:28:31 UTC
Help submitting a patch (test timeouts)
Hi,
I'm trying to submit a patch for a "simple" bug fix.
https://issues.apache.org/jira/browse/YARN-412
The Hudson build bot is complaining that one of the included tests does not
have a timeout. I've added a timeout to the test case that I added (using
@Test(timeout=2000)) but it still complains.
Do I need to add timeouts to the exist test cases in the same file that I
did not modify?
Cheers,
Roger
Re: Help submitting a patch (test timeouts)
Posted by Roger Hoover <ro...@gmail.com>.
Thank you, Steve. I tend to agree that timeouts in test code are brittle
b/c they're very sensitive to the environment in which the test is
executed.
On Sat, Feb 23, 2013 at 10:45 AM, Steve Loughran <st...@hortonworks.com>wrote:
> A change went in to the patch reviewer that now requires an timeout
> attribute, so as to ensure better handling of timing out tests on Jenkins
>
> https://issues.apache.org/jira/browse/HADOOP-9112
>
> I am one of the people who think that hard coding timeouts is the wrong
> solution to this problem. For now: either add a (timeout=) declaration in
> the @Test attribute, or post a reason justifying why it should be left out.
>
> On 21 February 2013 21:28, Roger Hoover <ro...@gmail.com> wrote:
>
> > Hi,
> >
> > I'm trying to submit a patch for a "simple" bug fix.
> >
> > https://issues.apache.org/jira/browse/YARN-412
> >
> > The Hudson build bot is complaining that one of the included tests does
> not
> > have a timeout. I've added a timeout to the test case that I added
> (using
> > @Test(timeout=2000)) but it still complains.
> >
> > Do I need to add timeouts to the exist test cases in the same file that I
> > did not modify?
> >
> > Cheers,
> >
> > Roger
> >
>
Re: Help submitting a patch (test timeouts)
Posted by Steve Loughran <st...@hortonworks.com>.
A change went in to the patch reviewer that now requires an timeout
attribute, so as to ensure better handling of timing out tests on Jenkins
https://issues.apache.org/jira/browse/HADOOP-9112
I am one of the people who think that hard coding timeouts is the wrong
solution to this problem. For now: either add a (timeout=) declaration in
the @Test attribute, or post a reason justifying why it should be left out.
On 21 February 2013 21:28, Roger Hoover <ro...@gmail.com> wrote:
> Hi,
>
> I'm trying to submit a patch for a "simple" bug fix.
>
> https://issues.apache.org/jira/browse/YARN-412
>
> The Hudson build bot is complaining that one of the included tests does not
> have a timeout. I've added a timeout to the test case that I added (using
> @Test(timeout=2000)) but it still complains.
>
> Do I need to add timeouts to the exist test cases in the same file that I
> did not modify?
>
> Cheers,
>
> Roger
>