You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/26 17:04:24 UTC

[GitHub] [kafka] mumrah commented on pull request #12403: KAFKA-13166 Fix missing ControllerApis error handling

mumrah commented on PR #12403:
URL: https://github.com/apache/kafka/pull/12403#issuecomment-1195746529

   Hey @cmccabe, thanks for the review! I agree it's a bit weird to return the completed feature here from the authorizer calls. I tried a few different approaches, and having all the handlers return the same type seemed to be a simple way to fix the error handling. The main issue I'm solving here is adding the final `whenComplete` to handle errors in completion handlers (which used to be `whenComplete`, but are now `handle` calls). 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org