[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3135: [GOBBLIN-1297] Register/unregister eventbus with dagManager on leadership change

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #3135:
URL: https://github.com/apache/incubator-gobblin/pull/3135#discussion_r509778219



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##########
@@ -417,6 +417,7 @@ private void  handleLeadershipChange(NotificationContext changeContext) {
         //Activate DagManager only if TopologyCatalog is initialized. If not; skip activation.
         if (this.topologyCatalog.getInitComplete().getCount() == 0) {
           this.dagManager.setActive(true);
+          this.eventBus.register(this.dagManager);

Review comment:
       Any chance we can update GobblinServiceHATest to verify that on leadership change the dagManager has been registered with the eventbus? e.g. construct a mock DagManager and pass it to GobblinServiceManager for it to register the mock dag manager?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org