You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/23 19:24:20 UTC

[GitHub] sijie commented on a change in pull request #1288: Add sync variants of all methods in handles

sijie commented on a change in pull request #1288: Add sync variants of all methods in handles
URL: https://github.com/apache/bookkeeper/pull/1288#discussion_r176840948
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/Handle.java
 ##########
 @@ -21,7 +21,7 @@
 package org.apache.bookkeeper.client.api;
 
 import java.util.concurrent.CompletableFuture;
-import lombok.SneakyThrows;
+import org.apache.bookkeeper.client.impl.BKExceptionHandler;
 
 Review comment:
   Make BKExceptionHandler.HANDLER as part of BKException. rather than having a separate class. this also prevent api package referencing impl package, which allows producing a clean api package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services